Conversation
Contributor
|
Thanks! |
Contributor
Author
|
Oh, I forgot to call |
Contributor
|
Is #142 required when google/gvisor#11609 is present in upstream? |
ignoramous
referenced
this pull request
Aug 28, 2025
Contributor
Author
google/gvisor#11609 didn't touch ICMPv6, as current gvisor never delivers ICMPv6 Echo Request Messages to TransportProtocolHandler, I suggest using iptables hack for now. 😇 Maybe libslirp in AVD is too old, I can't test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firestack misused
IPv4.SetHeaderLength(),replyHeaderLength >> 2is unnecessary.firestack/intra/netstack/icmp.go
Line 129 in 271e3d3
https://github.com/google/gvisor/blob/738e1d995f64d20fd11ab59a88d12b524acb672e/pkg/tcpip/header/ipv4.go#L298
The upstream has merged Amaindex's pull request google/gvisor#11609 , so my small changes should work.